Language: 
To browser these website, it's necessary to store cookies on your computer.
The cookies contain no personal information, they are required for program control.
  the storage of cookies while browsing this website, on Login and Register.

Author Topic:  Smileys  (Read 74 times)

0 Members and 1 Guest are viewing this topic.

Dolfo

« on: 21, March 2024, 07:28:35 »
Client is preparing smileys in misc.c smiley_convert(). Client is doing this before handling the linebreaks.

Inside this function we check for different combinations. The combinations "8)" "8 )" and ":0" are leading very often to unclean output, where client shows smileys in wrong situations.

Like time notations "20:00" or item values "cp 4.8)". One notation could also bug our colorbreaks, when we use ":" + a yellow toogle "|" we get the ":|" smiley instead.

Additionally we have also smileys in client, players can't trigger by typing, like ":|", "^_^", "^-^". But they are functionally and would break other logics we have.

We need a logic, which can recognize, if above situations are smileys or not smileys. That's not easy and need normaly a complexer logic. To keep it more simple, we could define simpler rules to help here out.

One could be "A smiley needs a space before or must be at start of line or directly behind another smiley."
This could be implemented very easy.

But then players would have to type this additionally spaces, for example:

"Morning :)"

Other logic could be Smileys need a space behind or an endline or other smileys behind. Then we would have to type
":) Morning"

So we need a rule, how we want differ "20:00" from ":0" or "(dps 1.8)" from "8)".

Also funny, that our forum has same problems at least with the "8 )" combination. 8)

Another option could be that we dissallow the shorter 2 char notatitions in this 2 cases and only allow the 3 char notations.

I use additionally spaces here, because of forum smileys
8 ) -> 8 - )
B) -> B - )
: 0 -> : - 0
...
But i would prefer to keep the short forms, and try a kind of logic around additionally spaces?
« Last Edit: 21, March 2024, 07:40:20 by Dolfo »
Don't believe the shit, you hear in mainstream. Believe your own body. Your body is speaking always the true to you. But you need to understand your body. Hear to your body, not to your ego. And when body is calling to you: "Hey something is wrong!" find the reason(s) for that. Man in White don't go for that, they don't want to heal you. They want earn money and sell you medicine, you should take rest of your life. You are not the patient, you are their customer. Never forget this!

Dolfo

« Reply #1 on: 23, March 2024, 14:15:22 »
I used rule one.

Now smileys need start of line, a space before or other smileys before.

« Last Edit: 23, March 2024, 14:18:55 by Dolfo »
Don't believe the shit, you hear in mainstream. Believe your own body. Your body is speaking always the true to you. But you need to understand your body. Hear to your body, not to your ego. And when body is calling to you: "Hey something is wrong!" find the reason(s) for that. Man in White don't go for that, they don't want to heal you. They want earn money and sell you medicine, you should take rest of your life. You are not the patient, you are their customer. Never forget this!

Tags:
 

Related Topics

  Subject / Started by Replies Last post
0 Replies
762 Views
Last post 30, April 2008, 08:43:35
by grommit
34 Replies
3891 Views
Last post 28, June 2010, 20:26:28
by Unislash
2 Replies
906 Views
Last post 06, April 2009, 14:31:28
by smacky