Author Topic: 65000 WC stat (Read 11985 times)

Joe

Main server:
For some reason having negative wc added to some items, drops it below 0 instead of stopping. The -wc was added to the new killrin agility gear in this months event.

smacky

It looks like this is a problem common to all primary (Str, etc) and secondary (WC, etc) stats and health indicators (hp, etc). Hard limits were not made server-side (for the most part -- hp 0 causes death at which point it is reset to max). Later, various ways to get boni/mali to these numbers were added, such as wc_add, etc object attributes and guild memberships, allowing them to have a wide range. Most crucially to drop below zero. While the server stores these as signed numbers (so negative is fine), the client interprets them as unsigned (so negative wraps around to a high positive).

The plugin contains some old TODO comments suggesting possible ranges. Some don't make sense (negative ac/wc/primaries?) and some are/will be outdated (primaries will be 0-200 or 0-250 not -30-30):

Code: [Select]

    /* TODO: Limit to +- 16000 ? */
    {"hitpoints",             FIELDTYPE_SINT32,    offsetof(object, stats.hp),                  0,                  0},
    {"max_hitpoints",         FIELDTYPE_SINT32,    offsetof(object, stats.maxhp),               FIELDFLAG_PLAYER_READONLY, 0},
    {"spellpoints",           FIELDTYPE_SINT16,    offsetof(object, stats.sp),                  0,                  0},
    {"max_spellpoints",       FIELDTYPE_SINT16,    offsetof(object, stats.maxsp),               FIELDFLAG_PLAYER_READONLY, 0},
    {"grace",                 FIELDTYPE_SINT16,    offsetof(object, stats.grace),               0,                  0},
    {"max_grace",             FIELDTYPE_SINT16,    offsetof(object, stats.maxgrace),            FIELDFLAG_PLAYER_READONLY, 0},
    /* TODO: Limit to max 999 (at least for players) ? */
    {"food",                  FIELDTYPE_SINT16,    offsetof(object, stats.food),                0,                  0},
    /* TODO: Limit to 0 <= dam <= 120 ? */
    {"damage",                FIELDTYPE_SINT16,    offsetof(object, stats.dam),                 FIELDFLAG_PLAYER_READONLY, 0},
    /* TODO: Limit to +-120 */
    {"weapon_class",          FIELDTYPE_SINT16,    offsetof(object, stats.wc),                  FIELDFLAG_PLAYER_READONLY, 0},
    /* TODO: Limit to +-120 */
    {"armour_class",          FIELDTYPE_SINT16,    offsetof(object, stats.ac),                  FIELDFLAG_PLAYER_READONLY, 0},
    /* TODO: Limit to +-30 (all  */
    {"strength",              FIELDTYPE_SINT8,     offsetof(object, stats.Str),                 FIELDFLAG_PLAYER_FIX, 0},
    {"dexterity",             FIELDTYPE_SINT8,     offsetof(object, stats.Dex),                 FIELDFLAG_PLAYER_FIX, 0},
    {"constitution",          FIELDTYPE_SINT8,     offsetof(object, stats.Con),                 FIELDFLAG_PLAYER_FIX, 0},
    {"wisdom",                FIELDTYPE_SINT8,     offsetof(object, stats.Wis),                 FIELDFLAG_PLAYER_FIX, 0},
    {"charisma",              FIELDTYPE_SINT8,     offsetof(object, stats.Cha),                 FIELDFLAG_PLAYER_FIX, 0},
    {"intelligence",          FIELDTYPE_SINT8,     offsetof(object, stats.Int),                 FIELDFLAG_PLAYER_FIX, 0},
    {"power",                 FIELDTYPE_SINT8,     offsetof(object, stats.Pow),                 FIELDFLAG_PLAYER_FIX, 0},
    {"thac0",                 FIELDTYPE_SINT8,     offsetof(object, stats.thac0),               FIELDFLAG_PLAYER_READONLY, 0},
    {"thacm",                 FIELDTYPE_SINT8,     offsetof(object, stats.thacm),               FIELDFLAG_PLAYER_READONLY, 0},

Shroud

That was quite informative. If anything it was a nice practical example of importance of using interfaces

It seems that bug is mostly cosmetic but I'll also note that I was quite surprised how often I managed to hit them so perhaps WC (and AC) aren't that important in determining if a mob is hit

Author Topic: 65000 WC stat (Read 11985 times)

Joe

65000 WC stat

smacky

Re: 65000 WC stat

Shroud

Re: 65000 WC stat

Related Topics