Author Topic: Bugs in 0.10.5-z (client and/or main server) (Read 104932 times)

Christophf

Hi,

after a problem with the trunk client, I've installed the stable one under Linux yesterday and found a few bugs so far:

1) Level drain

I'm at level 7, after removing death sickness, all my base values except experience, levels and HP, grace, mana are reset to those of a new player.

2) Quickslots are empty after logout and login

"quick.dat" is written to, but not reread on login. I've forced the writable directory in front of the PysFS search path with "-A=/path/to/home/subdirectory/of/daimonin", which doesn't help. Also deleting the old possibly corrupted file, causing the client to create a new one, doesn't help.

3) Missing file

"cancan.ogg" is searched for, but not found. This has apparently no consequences, but is mentioned on the client's stdout or stderr output.

4) Automatic server connection doesn't work

With 0.10.6 I could connect to the main server automatically from the command line. The 0.10.5-z client fails partially, it stops at the meta-server, login continues without asking for a password, however, if you choose the main server manually. It actually tries to log in, a red error message is briefly shown.

5) Unusable default keybindings on foreign keyboards

Some of the default keys do not work on the german keyboard I use, because those characters require control keys to be pressed additionally under normal circumstances. Example: "\" is "AltGr" (right "Alt" key) plus the key two places left from "Backspace" (upper row on main block). I can provide a list, and I suggest to switch to an internationally unproblematic layout eventually.

The first two bugs are the most severe, because there seems to be no workaround.

Regards, Christoph

Christophf

Quote from: Christophf on 14, April 2013, 13:10:34

1) Level drain

I'm at level 7, after removing death sickness, all my base values except experience, levels and HP, grace, mana are reset to those of a new player.

I just learned from someone in-game that the reason is that I've left the current guild, because statistics depend on membership rather than raising permanently. I'm not aware to have deliberately left the last guild, though.

I just became a mage in order to learn magic.

So I suspect that the bug is to be thrown out of the guild when having DS removed, or is this intentional?

Wait, does one become a mage by a accepting Jahrlen's quest? If not, this is not a bug, as it seems.

Christophf

Quote from: Christophf on 14, April 2013, 13:10:34

2) Quickslots are empty after logout and login

"quick.dat" is written to, but not reread on login. I've forced the writable directory in front of the PysFS search path with "-A=/path/to/home/subdirectory/of/daimonin", which doesn't help. Also deleting the old possibly corrupted file, causing the client to create a new one, doesn't help.

My "quick.dat" is growing, the settings for the same server and character are stored multiple times after one another. Apparently the first matching one, the empty entry, is read in on reconnect.

So the problem seems to be that a matching configuration (same server and character) is not overwritten, a new entry is appended instead.

Christoph

Christophf

Found something to append to the list:

6) Girdles useless?

Girdles do have protecting properties when examined, but no apparent effect when worn. There are no increase/decrease messages as for other armour pieces, there's also no change in the statistics display window.

7) Cat skins are "unusual"

You can normally place non-drop quest items (like keys) into containers carried with you, but not the 3 cat skins for the smith.

"/ready_skill" command

This command does not work any more. Has it been removed from the server?

smacky

Thanks for the reports Christophf. Programming (from me) is a little on hold right now due to RL issues, but to respond to your post:

Quote from: Christophf on 14, April 2013, 13:10:34

2) Quickslots are empty after logout and login

Yup, this is a riculously long-term problem that simply has never been fixed (but see below). One issue is that the 0.10.5 implementation does not use PhysFS (whereas all other file operations do IIRC) so basically the code gets confused at some point. Another problem is that the code for quickslots (much of which is quite old and dated) is ridiculously over-complicated which unsurprisingly leads to bugs.

Allegedly though this all was fixed recently-ish in 0.10.6 (trunk). I (or you) would need to check the SVN logs to see what exactly was done but IIRC it was a pretty simple basic fix. I say allegedly it was fixed because actually I've not tested it or even looked at the changes...

Quote

3) Missing file

"cancan.ogg" is searched for, but not found. This has apparently no consequences, but is mentioned on the client's stdout or stderr output.

IDR the details but basically an old developer added this for a map he was working on. Currently sound & music is a bit inflexible (even in such a basic way as this) For now it's safe to ignore it.

Quote

4) Automatic server connection doesn't work

Some of the server IPs changed but currently tthey are hardcoded into the client. 0.10.6 at least has the current ones but they're still hardcoded.

Quote

5) Unusable default keybindings on foreign keyboards

Some of the default keys do not work on the german keyboard I use, because those characters require control keys to be pressed additionally under normal circumstances. Example: "\" is "AltGr" (right "Alt" key) plus the key two places left from "Backspace" (upper row on main block). I can provide a list, and I suggest to switch to an internationally unproblematic layout eventually.

Agreed. The key word is 'eventually' though.

EDIT: Re /ready_skill: I don't really remember the details but I came across this issue not too long ago. I think whatever the actual cause was it's not a big deal currently anyway.

Christophf

Quote from: smacky on 14, April 2013, 16:24:21

Quote from: Christophf on 14, April 2013, 13:10:34
2) Quickslots are empty after logout and login

[

smacky

Hm...

(Not much more to say, need to look at the code history)

_people_

Quote from: Christophf on 14, April 2013, 14:24:40

Quote from: Christophf on 14, April 2013, 13:10:34
1) Level drain

I'm at level 7, after removing death sickness, all my base values except experience, levels and HP, grace, mana are reset to those of a new player.

I just learned from someone in-game that the reason is that I've left the current guild, because statistics depend on membership rather than raising permanently. I'm not aware to have deliberately left the last guild, though.

I just became a mage in order to learn magic.

So I suspect that the bug is to be thrown out of the guild when having DS removed, or is this intentional?

Wait, does one become a mage by a accepting Jahrlen's quest? If not, this is not a bug, as it seems.

Some stats are dependent upon guild membership. If you're level 7 then you shouldn't have access to the wizardry guild because that's stationed in SG. To learn spells from Jahrlen you'd have to speak with Cashin about leaving the Mercenary guild, which would remove the stats granted by the Mercenary guild. You should never be forced out of it, though. What guild is listed in the widget in the upper-left, with your name/deity/alignment? If you're still in the Merc guild you might have depletion, which is another malady which reduces stats. The priest can remove that as well.

#3: cancan.ogg is part of the unofficial content stuff. For some reason it's on a list of sound files, but it doesn't need to be. I've added music files to the server without adding them to any sort of list before. To be fair, though, I don't know much about our sound system so that may be the right way to go. Either way, only development clients complain about missing sound files.

Quote from: Christophf on 14, April 2013, 16:09:08

Found something to append to the list:

6) Girdles useless?

Girdles do have protecting properties when examined, but no apparent effect when worn. There are no increase/decrease messages as for other armour pieces, there's also no change in the statistics display window.

7) Cat skins are "unusual"

You can normally place non-drop quest items (like keys) into containers carried with you, but not the 3 cat skins for the smith.

"/ready_skill" command

This command does not work any more. Has it been removed from the server?

#6: The issue with girdles is that they don't offer *much* protection. The way we currently handle resistance boni sometimes results in the resistance table not changing because it's based on percentages.

#7: "Real" quest items are fairly odd in nature because they are a fake item. The object is of archetype "quest_object" but it's made to look somewhat like a real item, whereas keys are of archetype "key" and don't strictly have to be part of a quest/no-drop. I'm assuming that for some reason TYPE_QUEST_OBJECT objects cannot be put in containers. It might be for speed - since quests often have to loop through the inventory to find items and containers make it slower to find those items. IMO inventory searches should be done via a more efficient method like a hashtable.

#8: Haven't heard of this, I'll have to test it.

Christophf

Quote from: _people_They are still not saved (not tried an empty quickslot configuration file yet). on 14, April 2013, 19:56:51

Quote from: Christophf on 14, April 2013, 14:24:40
Quote from: Christophf on 14, April 2013, 13:10:34
1) Level drain

I'm at level 7, after removing death sickness, all my base values except experience, levels and HP, grace, mana are reset to those of a new player.

I just learned from someone in-game that the reason is that I've left the current guild, because statistics depend on membership rather than raising permanently. I'm not aware to have deliberately left the last guild, though.

I just became a mage in order to learn magic.

So I suspect that the bug is to be thrown out of the guild when having DS removed, or is this intentional?

Wait, does one become a mage by a accepting Jahrlen's quest? If not, this is not a bug, as it seems.

Some stats are dependent upon guild membership. If you're level 7 then you shouldn't have access to the wizardry guild because that's stationed in SG. To learn spells from Jahrlen you'd have to speak with Cashin about leaving the Mercenary guild, which would remove the stats granted by the Mercenary guild. You should never be forced out of it, though. What guild is listed in the widget in the upper-left, with your name/deity/alignment? If you're still in the Merc guild you might have depletion, which is another malady which reduces stats. The priest can remove that as well.

I've investigated this further and found that everything is working as expected. I get back the previous values when I rejoin the mercenaries' guild. I thought that the raise of thr physical values would be permanent and thought that their decrease was due to death sickness which it was only partially; I had left the guild because of Jahrlen, and I had forgotten that one can only join the mages' guild in SG.

Simply adding numbers, I found that a mercenary gets +1 overall, while a priest gets -3 compared to a non-guild-member (not sure if all numbers do change something right now; does Charisma work?)

Christoph

_people_

The stat numbers are balanced with other stats. Priests have lower primary stat boni but also get neat features like a 5% godpower attack. So overall it's *roughly* balanced. And yes, charisma is useful for getting higher shop prices.

Christophf

Quote from: _people_ on 14, April 2013, 19:56:51

Quote from: Christophf on 14, April 2013, 16:09:08
Found something to append to the list:
[...]
7) Cat skins are "unusual"

You can normally place non-drop quest items (like keys) into containers carried with you, but not the 3 cat skins for the smith.

#7: "Real" quest items are fairly odd in nature because they are a fake item. The object is of archetype "quest_object" but it's made to look somewhat like a real item, whereas keys are of archetype "key" and don't strictly have to be part of a quest/no-drop. I'm assuming that for some reason TYPE_QUEST_OBJECT objects cannot be put in containers. It might be for speed - since quests often have to loop through the inventory to find items and containers make it slower to find those items. IMO inventory searches should be done via a more efficient method like a hashtable.

I can confirm this for Crystal Fragments from the Burrow. A player unfortunately cannot see an objects "true nature", so it seems to be true that "real quest items" cannot be placed into a container, but your possible explanation is somewhat unsatisfactory: there are obviously other "quest items" of normal archetypes, where the same speed problems should apply, so containers must be searched anyway in general when looking for inventory items when the player presents a quest soltion to an NPC.

It's not a problem as such that some items cannot be put into a container, but there is no logic from a player's point of view, and in all other cases i saw the game would give you a reason why the item cannot be put into the container, but in these quest item cases it just doesn't work.

Christoph

Christophf

Even more issues:

9) Numbering bug when putting items into containers

The game always says someting like: "you cannot put $PILE_SIZE into $CONTAINER", not the actual number of items you're trying to add. Example to reproduce:

a) Get a pile of 501 copper coins and a normal purse.
b) Put 499 coins into the purse, which should work.
c) From the remaining pile of 2, put 1 more coin into the purse.

The game will complain that you cannot put 2 coins into the purse, because its weight limit has been reached. It should say "1", because you wanted to add only one item from the pile of two.

10) Chat bug with marked item properties variable

Some items double the resistances when their properties are posted to a chat channel. This happens with a mugwump amulet
and another cursed amulet i found, but not with all items.

To reproduce:
a) Mark an item.
b) Post "/channel x$" to have properties displayed in channel "x".

You'll find the following: either everything is normal, or the resistances (and only these) are listed twice, depending on the item. I've seen that happen on amulets so far and somethimg other I forgot.

11) Weird torch

I've used a pine torch normally for a while and extinguished it. This torch now cannot be lighted any more, in spite of not being burnt out. Applying it states that it is out of fuel and must be refilled; using oil on it doesn't work.

You can find this torch at the moment in the appartment of character Christophfr on the bed in case you need it for further investigation.

Obliterator has looked into the issues 10) and 11) in-game, but found no reasons for what was happening.

clobber

11 is a known bug. Each item of light has a certain amount of ticks - that is the time it is applied for. When these run out, the light source is extinguished, or burnt out. In this case, if you unlight the torch just as it runs out, it has 0 ticks, but the image isn't changed so you still are unable to light it.

Christophf

Another two I had forgotten:

12) Message window colours wrong

When examining the one-drop egobound spider shield from the labyrinth, the green colourerd parts are wrong. I don't know the triggers for "greening" and "ungreening" the font, I suspect that a bracket is misinterpreted.

13) Unreadable wall posters

I've last done that in 2008 or early 2009, I think, so I don't remember exactly, but I think in B4 wall posters were once readable. If I'm not mistaken, the one in the labyrinth contained a hint how to cross the floor hole rows, for example.

From an in-game discussion I learned that they are now on "layer 7" and visible, but not applyable.

clobber

You're a busy man

I can fix 12 (perhaps) and 13, and will over the weekend.

Number 10 may be fixed on the 10.6 server, by a recent update Smacky made.

Author Topic: Bugs in 0.10.5-z (client and/or main server) (Read 104932 times)

Christophf

Bugs in 0.10.5-z (client and/or main server)

Christophf

Re: Bugs in 0.10.5-z (client and/or main server)

Christophf

Re: Bugs in 0.10.5-z (client and/or main server)

Christophf

Some more issues

smacky

Re: Bugs in 0.10.5-z (client and/or main server)

Christophf

Re: Bugs in 0.10.5-z (client and/or main server)

smacky

Re: Bugs in 0.10.5-z (client and/or main server)

_people_

Re: Bugs in 0.10.5-z (client and/or main server)

Christophf

Re: Bugs in 0.10.5-z (client and/or main server)

_people_

Re: Bugs in 0.10.5-z (client and/or main server)

Christophf

Re: Bugs in 0.10.5-z (client and/or main server)

Christophf

Re: Bugs in 0.10.5-z (client and/or main server)

clobber

Re: Bugs in 0.10.5-z (client and/or main server)

Christophf

Re: Bugs in 0.10.5-z (client and/or main server)

clobber

Re: Bugs in 0.10.5-z (client and/or main server)

Related Topics